Add failAfterTime to limit maximum time elapsed#22
Open
kevinoid wants to merge 1 commit intoMathieuTurcotte:masterfrom
Open
Add failAfterTime to limit maximum time elapsed#22kevinoid wants to merge 1 commit intoMathieuTurcotte:masterfrom
kevinoid wants to merge 1 commit intoMathieuTurcotte:masterfrom
Conversation
This commit adds the failAfterTime method to Backoff (and FunctionCall) to allow limiting the total elapsed time. The primary intended use case is when the caller has a deadline which can not be exceeded during which to retry an operation with backoff and the number of backoffs can not be calculated in advance (e.g. because the operation takes a variable amount of time). Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Author
|
Ping. Thoughts? |
|
@MathieuTurcotte ping? |
Owner
|
The change makes sense at a glance. I'll try to take a closer look this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a
failAfterTimemethod toBackoff(andFunctionCall) to allow limiting the total elapsed time. The primary intended use case is when the caller has a deadline which can not be exceeded during which to retry an operation with backoff and the number of backoffs can not becalculated in advance (e.g. because the operation takes a variable amount of time). In my current use case, this is calling a REST API using backoff up to a deadline.
Thanks for considering,
Kevin